The Agile Way

The Agile Way

Share this post

The Agile Way
The Agile Way
Formal Code Review Process ๐Ÿ‘Ž๐Ÿฝ and Collective Code Ownership ๐Ÿ‘

Formal Code Review Process ๐Ÿ‘Ž๐Ÿฝ and Collective Code Ownership ๐Ÿ‘

Avoid the Formal Code Review Process and embrace โ€œCollective Code Ownership.โ€

Zhimin Zhan's avatar
Zhimin Zhan
Sep 05, 2024
โˆ™ Paid
1

Share this post

The Agile Way
The Agile Way
Formal Code Review Process ๐Ÿ‘Ž๐Ÿฝ and Collective Code Ownership ๐Ÿ‘
Share

A repost of my article on Medium.

I have written two articles on the Code Review process.

  • Formal Code Review Process is No Good

  • Fake Code Review with โ€˜LGTMโ€™

In this article, I will discuss Code Review with an Agile term: โ€œCollective code ownership,โ€ which many of this generation of software professionals are unfamiliar with.

โ€œCollective code ownership, as the name suggests, is the explicit convention that โ€œeveryโ€ team member is not only allowed, but in fact has a positive duty, to make changes to โ€œanyโ€ code file as necessary: either to complete a development task, to repair a defect, or even to improve the codeโ€™s overall structure.โ€
โ€” Agile Alliance

Yes, encourage the developers to change code without permission or waiting. I led a few client projects this way, which worked very well. I know many readers might have doubts. Check out this thought-provoking interview with Steve Jobs.

Full video: https://www.linkedin.com/feed/update/urn:li:activity:7228753358902153217/
Image preview

This spirit of โ€œCollective Code Ownershipโ€ contradicts the โ€œwaiting for approvalโ€ step, as you find in the common code review process nowadays.

Before I go further, I want to point out that โ€œCollective Code Ownershipโ€ is an Agile Glossary.

https://www.agilealliance.org/glossary/collective-ownership/

The โ€œCode Review (Requires Approval)โ€ is NOT, but it often appears in commercial tool websites, such as:

  • https://www.atlassian.com/agile/software-development/code-reviews

  • https://github.com/features/code-review

  • https://docs.gitlab.com/ee/development/code_review.html

Donโ€™t underestimate the commercial influence; it can brainwash people. The following comment from Linus Torvalds, creator of Git and Linux, will wake some people.

Keep reading with a 7-day free trial

Subscribe to The Agile Way to keep reading this post and get 7 days of free access to the full post archives.

Already a paid subscriber? Sign in
ยฉ 2025 Zhimin Zhan
Privacy โˆ™ Terms โˆ™ Collection notice
Start writingGet the app
Substack is the home for great culture

Share